Skip to content

Inspector V2: Tools Pane Init #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2025

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Jun 24, 2025

Partial Tools pane implementation. Have left TODO comments for missing sections.

The idea is that the components of the Tools pane are lumped into three extensible categories, which can be installed via the Extensions Manager: Export, Capture, and Import tools.

Images:
image
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@alexchuber alexchuber force-pushed the inspector-v2-tools-init branch from 4559e7a to a834b39 Compare June 24, 2025 15:30
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Copy link

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label Jul 23, 2025
@alexchuber alexchuber force-pushed the inspector-v2-tools-init branch from a834b39 to 389e780 Compare August 4, 2025 23:01
@alexchuber alexchuber force-pushed the inspector-v2-tools-init branch from c882b09 to f04118b Compare August 4, 2025 23:05
@alexchuber alexchuber marked this pull request as ready for review August 4, 2025 23:06
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@ryantrem ryantrem enabled auto-merge (squash) August 7, 2025 18:51
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/?snapshot=refs/pull/16798/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2025

@ryantrem ryantrem merged commit c9df5bd into BabylonJS:master Aug 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants