CMakeLists.txt: include CXX in project languages only when using TBB - #519
Open
stefan-sedlak wants to merge 2 commits into
Open
CMakeLists.txt: include CXX in project languages only when using TBB#519stefan-sedlak wants to merge 2 commits into
stefan-sedlak wants to merge 2 commits into
Conversation
Avoids unnecessarily enabling the C++ toolchain when TBB support is disabled.
There was a problem hiding this comment.
Pull request overview
This PR makes the C++ language enablement in the CMake build conditional on TBB being requested. Previously, project() always enabled C/CXX/ASM, which required a C++ toolchain even for pure-C builds. With this change, CXX is only enabled when BLAKE3_USE_TBB or BLAKE3_FETCH_TBB is set, and the cxx_std_20 compile feature is likewise gated on those options.
Changes:
- Moved
BLAKE3_USE_TBB/BLAKE3_FETCH_TBBoptions before theproject()call and derivedBLAKE3_LANGUAGESfrom them. project()now usesLANGUAGES ${BLAKE3_LANGUAGES}instead of a hardcodedC CXX ASM.- Wrapped the
cxx_std_20target_compile_featurescall in a TBB-conditional block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Hi @BurningEnlightenment , could you please merge it? Or shall I improve something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids unnecessarily enabling the C++ toolchain when TBB support is disabled.