Skip to content

Conversation

@prjemian
Copy link
Contributor

@prjemian prjemian commented Oct 9, 2024

@prjemian prjemian added the task Something to be done. label Oct 9, 2024
@prjemian prjemian self-assigned this Oct 9, 2024
@prjemian
Copy link
Contributor Author

The challenge here is with the code needed to handle the metadata. There's a lot of metadata and the handling obscures the real functions of the code.

@prjemian
Copy link
Contributor Author

prjemian commented Oct 16, 2024

@qzhang234 @MDecarabas @banubot

We need to:

  • identify missing or out-of-order steps
  • test that this code works, be very skeptical
  • find ways to make it easier to generalize
  • merge it with main once it is acceptable

Here are the main sections of the xpcs_mesh_with_dm() plan:

grep "#! " ./src/instrument/plans/mesh_plans.py 
    #! 'title' must be safe to use as a file name (no spaces or special chars)
    #! Check inputs before configuration. Fail early, fail hard!
    #! Area detector.
    #! DM parameters
    #! Organize metadata: BS, DM
    #! Setup area detector HDF5 plugin (with data_path)
    #! DM DAQ upload the QMAP file to @voyager
    #! NeXus master file
    #! Data Acquisition: run the bluesky plan, wait for the files
    #! Start DM workflow (optional: and wait for it to finish)
    #! Upload bluesky run metadata to APS DM
    #! complete

@prjemian prjemian marked this pull request as ready for review October 16, 2024 21:33
@qzhang234 qzhang234 merged commit 66c5a7a into main Oct 17, 2024
@prjemian
Copy link
Contributor Author

Was this tested?

@qzhang234
Copy link
Collaborator

qzhang234 commented Oct 17, 2024 via email

@prjemian
Copy link
Contributor Author

Might have gotten ahead of ourselves on that.

@qzhang234
Copy link
Collaborator

qzhang234 commented Oct 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Something to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DM to xpcs_mesh scan

5 participants