-
Notifications
You must be signed in to change notification settings - Fork 1
Add DM workflow controls to xpcs mesh plan #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjemian
commented
Oct 9, 2024
- close Add DM to xpcs_mesh scan #81
Contributor
Author
|
The challenge here is with the code needed to handle the metadata. There's a lot of metadata and the handling obscures the real functions of the code. |
Contributor
Author
|
@qzhang234 @MDecarabas @banubot We need to:
Here are the main sections of the grep "#! " ./src/instrument/plans/mesh_plans.py
#! 'title' must be safe to use as a file name (no spaces or special chars)
#! Check inputs before configuration. Fail early, fail hard!
#! Area detector.
#! DM parameters
#! Organize metadata: BS, DM
#! Setup area detector HDF5 plugin (with data_path)
#! DM DAQ upload the QMAP file to @voyager
#! NeXus master file
#! Data Acquisition: run the bluesky plan, wait for the files
#! Start DM workflow (optional: and wait for it to finish)
#! Upload bluesky run metadata to APS DM
#! complete |
banubot
reviewed
Oct 17, 2024
banubot
reviewed
Oct 17, 2024
banubot
reviewed
Oct 17, 2024
MDecarabas
approved these changes
Oct 17, 2024
Contributor
Author
|
Was this tested? |
Collaborator
|
Hi Pete:
I'm working on the test right now. Should I not merge it to the main branch?
Thanks,
QZ
…________________________________
From: Pete R Jemian ***@***.***>
Sent: Thursday, October 17, 2024 10:29 AM
To: aps-8id-dys/bluesky ***@***.***>
Cc: Zhang, Qingteng ***@***.***>; State change ***@***.***>
Subject: Re: [aps-8id-dys/bluesky] Add DM workflow controls to xpcs mesh plan (PR #84)
Was this tested? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state. Message ID: <aps-8id-dys/bluesky/pull/84/c2419865320@ github. com>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Was this tested?
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/aps-8id-dys/bluesky/pull/84*issuecomment-2419865320__;Iw!!G_uCfscf7eWS!aQ2xy832vYCwf2ZwAhBBzCUpZC0a80PelffaWTHJ4iBQvziJ_289QJW48ANbT-VAg_njN4RlcUEXf0TWqfwig61GTgxYgg$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/ALPJBQU6LUQN36YXPQK35O3Z37JVTAVCNFSM6AAAAABPVSY7MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZHA3DKMZSGA__;!!G_uCfscf7eWS!aQ2xy832vYCwf2ZwAhBBzCUpZC0a80PelffaWTHJ4iBQvziJ_289QJW48ANbT-VAg_njN4RlcUEXf0TWqfwig63wKUO8sQ$>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Contributor
Author
|
Might have gotten ahead of ourselves on that. |
Collaborator
|
Hi Pete:
I apologize. I reversed the pull request and now we have a working 'main' branch at the beamline. Which branch should I checkout if I want to test your Eiger code in this issue?
Thanks,
QZ
…________________________________
From: Pete R Jemian ***@***.***>
Sent: Thursday, October 17, 2024 10:59 AM
To: aps-8id-dys/bluesky ***@***.***>
Cc: Zhang, Qingteng ***@***.***>; State change ***@***.***>
Subject: Re: [aps-8id-dys/bluesky] Add DM workflow controls to xpcs mesh plan (PR #84)
Might have gotten ahead of ourselves on that. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state. Message ID: <aps-8id-dys/bluesky/pull/84/c2419933803@ github. com>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Might have gotten ahead of ourselves on that.
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/aps-8id-dys/bluesky/pull/84*issuecomment-2419933803__;Iw!!G_uCfscf7eWS!bnHeA0yKi_V6MEdFxaIPiInOeN0kp9aFpqyoZHPR2CIKgBS2ygPkhb71SJmNzSF1q9cpKyNJYuoG3zWI5S2fdpfI4bkyVg$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/ALPJBQV7MWOCIQNY4FYBCKLZ37NEXAVCNFSM6AAAAABPVSY7MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZHEZTGOBQGM__;!!G_uCfscf7eWS!bnHeA0yKi_V6MEdFxaIPiInOeN0kp9aFpqyoZHPR2CIKgBS2ygPkhb71SJmNzSF1q9cpKyNJYuoG3zWI5S2fdpdq3-rqlQ$>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.