Skip to content

Conversation

@prjemian
Copy link
Contributor

@prjemian prjemian commented Jun 3, 2024

@prjemian prjemian added the enhancement New feature or request label Jun 3, 2024
@prjemian prjemian requested review from MDecarabas and qzhang234 June 3, 2024 19:31
@prjemian prjemian self-assigned this Jun 3, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Jun 3, 2024

I tested this in an IPython console session. After merge, this will need to be pulled to the beam line's account. (I created the branch offline from the beam line.)

In [2]: mr1.connected
Out[2]: True

In [3]: mr2.connected
Out[3]: True

In [4]: mr1.read()
Out[4]: 
OrderedDict([('mr1_x',
              {'value': 1540.3944000000001, 'timestamp': 1717442261.539049}),
             ('mr1_x_user_setpoint',
              {'value': 1540.41145, 'timestamp': 1717442252.604055}),
             ('mr1_y', {'value': 1246.96295, 'timestamp': 1717442261.539026}),
             ('mr1_y_user_setpoint',
              {'value': 1246.96215, 'timestamp': 1717442259.957363}),
             ('mr1_coarse_pitch',
              {'value': 0.28169, 'timestamp': 1717442261.539074}),
             ('mr1_coarse_pitch_user_setpoint',
              {'value': 0.3072078, 'timestamp': 1717442249.027314}),
             ('mr1_fine_pitch', {'value': 0.0145, 'timestamp': 631152000.0}),
             ('mr1_fine_pitch_user_setpoint',
              {'value': 0.0145, 'timestamp': 631152000.0}),
             ('mr1_flag',
              {'value': 899.9992500000001, 'timestamp': 1717442259.033352}),
             ('mr1_flag_user_setpoint',
              {'value': 899.9992500000001, 'timestamp': 1717442248.552952})])

@prjemian
Copy link
Contributor Author

prjemian commented Jun 3, 2024

Bluesky connects to the motor PVs. Device .read() method works. I'm convinced this should work as expected.

@prjemian
Copy link
Contributor Author

prjemian commented Jun 3, 2024

Since the fine_pitch and the flag have different PV patterns, the best-fit prefix was just the IOC. Also, could not subclass Mirror2 from Mirror1 without some other gymnastics. This is so simple, it was not worth doing that.

Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian prjemian changed the title ENH #15 add HHL Slit devices: mr1 & mr2 ENH #15 add HHL Mirrors: mr1 & mr2 Jun 4, 2024
@prjemian prjemian merged commit 9b2b405 into main Jun 4, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Jun 4, 2024

@MDecarabas Thanks. I fixed the typo, too.

@MDecarabas MDecarabas deleted the 8-ID-A-HHL-Mirrors branch June 28, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HHL Mirrors:

3 participants