Skip to content

ophyd name kwarg values should be valid python object names #67

@prjemian

Description

@prjemian

The name="VALUE" kwarg should be a valid Python name.

Names such as these should be changed: https://github.com/aps-8id-dys/bluesky/blob/7ccd08c563eabc008954e55a2de48c468d7ff52a/src/instrument/devices/slit.py#L43-L47

While this is a naming convention that is not checked by the ophyd code, the names are used later to retrieve and reference data from the databroker or tiled. Names which are not suitable as Python object names are problematic to the end users.

This regular expression (derived from NeXus) is a good test for names: ^[a-zA-Z_]([a-zA-Z0-9_]*)?$

It has been recommended that the name match the Python object name unless a compelling reason suggestion otherwise.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions