Skip to content

Fix undefined behaviour in SHA-256 byte-loading by casting to WORD be… #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0300dbdd1b
Copy link

Clang’s UndefinedBehaviorSanitizer reports:

  runtime error: left shift of 255 by 24 places cannot be represented in type 'int'

Because each data byte (0–255) is promoted to a signed int before shifting, `255 << 24` overflows a 32-bit signed range.  

Cast input bytes to WORD before shifting to prevent signed-integer overflow UB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant