Skip to content

Conversation

sruke
Copy link
Contributor

@sruke sruke commented Mar 11, 2025

Updates CodeQL.yaml to exclude test files

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@sruke sruke requested a review from a team as a code owner March 11, 2025 16:15
@sruke sruke self-assigned this Mar 11, 2025
@sruke sruke requested a review from Copilot March 11, 2025 16:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the CodeQL.yaml configuration file to exclude test and benchmark directories without using the wildcard pattern.

  • Updated exclusion patterns for tests and benchmark directories
  • Changed exclusion pattern for docs to remove the trailing wildcard
  • Updated configuration comments in accordance with CodeQL documentation
Comments suppressed due to low confidence (2)

CodeQL.yaml:10

  • Verify that excluding 'tests' without the wildcard pattern still correctly excludes all test files, as the glob behavior may differ from expectations.
    - "tests"

CodeQL.yaml:13

  • Confirm that switching from 'docs/**' to 'docs' properly covers all documentation files, ensuring that subdirectories are excluded as intended.
    - "docs"

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sruke sruke merged commit 690cea4 into master Mar 11, 2025
5 checks passed
@sruke sruke deleted the sruthi/CodeQl branch March 11, 2025 17:13
This was referenced Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants