Adding WithExtraBodyParameters api #5389
Open
+466
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 18, 2025
src/client/Microsoft.Identity.Client.Extensions.Msal/Shared/StorageCreationPropertiesBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
bgavrilMS
reviewed
Jul 22, 2025
bgavrilMS
reviewed
Jul 29, 2025
| /// <param name="builder"></param> | ||
| /// <param name="extrabodyparams">List of additional body parameters</param> | ||
| /// <returns></returns> | ||
| public static AcquireTokenForClientParameterBuilder WithExtraBodyParameters( |
There was a problem hiding this comment.
Thx, can you also pls log a feature request to the same for WithExtraQueryParameters? i.e. associate tokens with those params?
bgavrilMS
approved these changes
Jul 29, 2025
| @@ -27,10 +28,10 @@ internal class AcquireTokenCommonParameters | |||
| public IAuthenticationOperation AuthenticationOperation { get; set; } = new BearerAuthenticationOperation(); | |||
| public IDictionary<string, string> ExtraHttpHeaders { get; set; } | |||
| public PoPAuthenticationConfiguration PopAuthenticationConfiguration { get; set; } | |||
| public Func<OnBeforeTokenRequestData, Task> OnBeforeTokenRequestHandler { get; internal set; } | |||
| public IList<Func<OnBeforeTokenRequestData, Task>> OnBeforeTokenRequestHandler { get; internal set; } | |||
There was a problem hiding this comment.
Why is this changed to a list object? Are we expecting to have this set multiple times?
| } | ||
| } | ||
|
|
||
| private Task<string> GetPdpAuthorization() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
This PR adds a new extensibility API
WithExtraBodyParameters(Dictionary<string, Func<CancellationToken, Task<string>>> extrabodyparams)The body params are in the form of
Dictionary<string, Func<CancellationToken, Task<string>>>because this will give developers an opportunity to provide a delegate to achieve the dictionary value because it is possible that it may change depending on when it is acquired.These parameters are added to the body parameters of the outgoing request and they are added to the cache key. This way, the tokens acquired with these parameters will only be retrieved when the same parameters are provided.
Testing
Unit/Manual
Documentation