feat: add events for mcs controller #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainred
approved these changes
Aug 19, 2022
Member
mainred
left a comment
mainred
left a comment
There was a problem hiding this comment.
Left several nits. Prefer %s for string over %v.
michaelawyu
reviewed
Aug 22, 2022
michaelawyu
reviewed
Aug 22, 2022
michaelawyu
reviewed
Aug 22, 2022
michaelawyu
reviewed
Aug 22, 2022
michaelawyu
reviewed
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Requirements:
make reviewablefor basic local testHow has this code been tested
We use the events for INFO only and we don't test them for now because of the maintenance overhead and integration test flakiness
Special notes for your reviewer