Skip to content

Conversation

@Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Jul 25, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds an init container to hub-net-controller-manager, member-net-controller-manager deployment charts to install CRDs.

it also addresses some misc issues with the E2E setup,

  • specifies the VM size of AKS clusters created for E2Es to be A-series, since we build our images with platform specified as linux/amd64 the corresponding VM must also match the same ARCH
  • specifies platform to linux/amd64 for an hello-world app we build to test in our E2E

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

E2E run with the latest changes https://github.com/Azure/fleet-networking/actions/runs/16761213078

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 45.83333% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.41%. Comparing base (5b85588) to head (96120a7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/net-crd-installer/main.go 0.00% 56 Missing ⚠️
cmd/net-crd-installer/utils/util.go 75.00% 16 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #325       +/-   ##
===========================================
- Coverage   78.66%   67.41%   -11.25%     
===========================================
  Files          29       34        +5     
  Lines        4246     5046      +800     
===========================================
+ Hits         3340     3402       +62     
- Misses        723     1454      +731     
- Partials      183      190        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arvindthiru Arvindthiru force-pushed the networkCRDInstaller branch from 4c27a55 to 476ad16 Compare July 29, 2025 02:34
@Arvindthiru Arvindthiru force-pushed the networkCRDInstaller branch from 5b7bb07 to 88b44b4 Compare July 31, 2025 00:13
@Arvindthiru Arvindthiru marked this pull request as ready for review August 1, 2025 23:14
@ryanzhang-oss ryanzhang-oss requested a review from Copilot August 4, 2025 20:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a CRD installer init container to the hub and member network controller manager deployments, allowing CRDs to be installed automatically without manual kubectl apply commands. The PR also fixes E2E test infrastructure issues by specifying VM sizes and platform architecture for consistency.

  • Introduces a new net-crd-installer init container that automatically installs required CRDs based on mode (hub/member)
  • Updates E2E test scripts to use Standard_A2_v2 VM sizes for AKS clusters to match linux/amd64 platform requirements
  • Enhances log collection to capture init container logs and adds platform specification for Docker builds

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/net-crd-installer/main.go New main entry point for CRD installer with mode-based CRD installation logic
cmd/net-crd-installer/utils/util.go Core utility functions for CRD collection, installation, and file processing
docker/net-crd-installer.Dockerfile Dockerfile for building the CRD installer container image
charts/hub-net-controller-manager/templates/deployment.yaml Adds init container configuration for hub deployments
charts/member-net-controller-manager/templates/deployment.yaml Adds init container configuration for member deployments
test/scripts/bootstrap.sh Updates E2E setup to use CRD installer and specifies platform for Docker builds
test/scripts/collect-logs.sh Enhances log collection to capture init container logs
Makefile Adds build targets for the new CRD installer image
Multiple test scripts Specifies Standard_A2_v2 VM size for AKS clusters in E2E tests

@Arvindthiru Arvindthiru force-pushed the networkCRDInstaller branch from 5a5fb51 to 6710818 Compare August 4, 2025 23:45
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, PTAL.

@Arvindthiru Arvindthiru merged commit 98d3bbe into Azure:main Aug 7, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants