-
Notifications
You must be signed in to change notification settings - Fork 19
feat: CRD installer init container #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
===========================================
- Coverage 78.66% 67.41% -11.25%
===========================================
Files 29 34 +5
Lines 4246 5046 +800
===========================================
+ Hits 3340 3402 +62
- Misses 723 1454 +731
- Partials 183 190 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4c27a55 to
476ad16
Compare
5b7bb07 to
88b44b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a CRD installer init container to the hub and member network controller manager deployments, allowing CRDs to be installed automatically without manual kubectl apply commands. The PR also fixes E2E test infrastructure issues by specifying VM sizes and platform architecture for consistency.
- Introduces a new
net-crd-installerinit container that automatically installs required CRDs based on mode (hub/member) - Updates E2E test scripts to use Standard_A2_v2 VM sizes for AKS clusters to match linux/amd64 platform requirements
- Enhances log collection to capture init container logs and adds platform specification for Docker builds
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cmd/net-crd-installer/main.go |
New main entry point for CRD installer with mode-based CRD installation logic |
cmd/net-crd-installer/utils/util.go |
Core utility functions for CRD collection, installation, and file processing |
docker/net-crd-installer.Dockerfile |
Dockerfile for building the CRD installer container image |
charts/hub-net-controller-manager/templates/deployment.yaml |
Adds init container configuration for hub deployments |
charts/member-net-controller-manager/templates/deployment.yaml |
Adds init container configuration for member deployments |
test/scripts/bootstrap.sh |
Updates E2E setup to use CRD installer and specifies platform for Docker builds |
test/scripts/collect-logs.sh |
Enhances log collection to capture init container logs |
Makefile |
Adds build targets for the new CRD installer image |
| Multiple test scripts | Specifies Standard_A2_v2 VM size for AKS clusters in E2E tests |
5a5fb51 to
6710818
Compare
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, PTAL.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds an init container to hub-net-controller-manager, member-net-controller-manager deployment charts to install CRDs.
it also addresses some misc issues with the E2E setup,
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer
E2E run with the latest changes https://github.com/Azure/fleet-networking/actions/runs/16761213078