-
Notifications
You must be signed in to change notification settings - Fork 19
test: add e2e tests to validate customHeaders of trafficManagerProfile #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: zhiying-lin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 80.61% 80.58% -0.04%
==========================================
Files 29 29
Lines 4153 4161 +8
==========================================
+ Hits 3348 3353 +5
- Misses 641 643 +2
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR adds comprehensive end-to-end tests to validate that customHeaders in TrafficManagerProfile specifications are properly propagated to Azure Traffic Manager profiles.
Changes Made
1. Updated
buildDesiredATMProfilehelper functionAdded support for customHeaders in the test helper function to mirror the controller implementation:
2. Added new e2e test case
Added a comprehensive test case "Updating the trafficManagerProfile with customHeaders" that validates:
Test Coverage
The new test covers the complete lifecycle of customHeaders:
Implementation Details
atmValidator.ValidateProfile) as other testsgenerateAzureTrafficManagerProfileThis ensures that the customHeaders feature is thoroughly tested end-to-end, validating proper propagation from Kubernetes TrafficManagerProfile resources to actual Azure Traffic Manager profiles.
Fixes #313.
E2E tests
https://github.com/Azure/fleet-networking/actions/runs/15344659627 are green