Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Mar 19, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
use the serviceExport generation instead of service
Note: service does not have the generation.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

e2e tests passed, https://github.com/Azure/fleet-networking/actions/runs/13986059012

Special notes for your reviewer

The change should not break the mcs or atm, and they're using serviceImport instead of serviceExport.

@zhiying-lin zhiying-lin marked this pull request as draft March 19, 2025 09:38
@zhiying-lin zhiying-lin changed the title fix the generation fix: fix the service export condition Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (6c08b0b) to head (dbe2b2e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/member/serviceexport/controller.go 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   80.24%   80.26%   +0.01%     
==========================================
  Files          29       29              
  Lines        4020     4024       +4     
==========================================
+ Hits         3226     3230       +4     
  Misses        633      633              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhiying-lin zhiying-lin marked this pull request as ready for review March 21, 2025 07:40
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not counting other added comments ;)

Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@zhiying-lin zhiying-lin merged commit 5c38041 into Azure:main Mar 26, 2025
10 checks passed
@zhiying-lin zhiying-lin deleted the fix-conflict branch March 26, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants