-
Notifications
You must be signed in to change notification settings - Fork 19
fix: fix the service export condition #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7d5efe to
0930823
Compare
12028d5 to
542a864
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 80.24% 80.26% +0.01%
==========================================
Files 29 29
Lines 4020 4024 +4
==========================================
+ Hits 3226 3230 +4
Misses 633 633
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not counting other added comments ;)
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
What type of PR is this?
/kind bug
What this PR does / why we need it:
use the serviceExport generation instead of service
Note: service does not have the generation.
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
e2e tests passed, https://github.com/Azure/fleet-networking/actions/runs/13986059012
Special notes for your reviewer
The change should not break the mcs or atm, and they're using serviceImport instead of serviceExport.