-
Notifications
You must be signed in to change notification settings - Fork 19
docs: add a demo #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a demo #275
Conversation
docs/demos/TrafficManagerProfile/testfiles/eastus2euap/ro-nginx-service-export-eastus2euap.yaml
Show resolved
Hide resolved
Title(Describe updated until commit 8deff3a)docs: add a demo User descriptionWhat type of PR is this? What this PR does / why we need it: Which issue(s) this PR fixes: Fixes # Requirements:
How has this code been testedSpecial notes for your reviewerPR Typedocumentation Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍(Review updated until commit 8deff3a)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few nits, otherwise LGTM
docs/demos/TrafficManagerProfile/session-build-multi-clsuter-app/README.md
Outdated
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-build-multi-clsuter-app/README.md
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-build-multi-clsuter-app/README.md
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-anothe-region/README.md
Outdated
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-anothe-region/README.md
Outdated
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-another-cluster/README.md
Outdated
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-another-cluster/README.md
Outdated
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-another-cluster/README.md
Show resolved
Hide resolved
docs/demos/TrafficManagerProfile/session-migrate-to-another-cluster/README.md
Outdated
Show resolved
Hide resolved
|
Persistent review updated to latest commit 7a612a7 |
|
Persistent review updated to latest commit 8deff3a |
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer