Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@zhiying-lin zhiying-lin marked this pull request as draft March 12, 2025 09:35
@zhiying-lin zhiying-lin marked this pull request as ready for review April 3, 2025 14:12
@kaito-pr-agent
Copy link

kaito-pr-agent bot commented Apr 3, 2025

Title

(Describe updated until commit 8deff3a)

docs: add a demo


User description

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer


PR Type

documentation


Description

  • Added comprehensive documentation for deploying a multi-cluster application using Azure Kubernetes Fleet Manager.

  • Included detailed steps and configurations for seamless cluster migration and traffic control.

  • Provided examples and test files for practical implementation.


Changes walkthrough 📝

Relevant files
Documentation
19 files
README.md
Add README for Traffic Manager Profile demos                         
+12/-0   
README.md
Add detailed steps for deploying a multi-cluster application
+225/-0 
README.md
Add detailed steps for seamless cluster migration and traffic control
+190/-0 
README.md
Add detailed steps for migrating applications across regions
+222/-0 
crp.yaml
Add ClusterResourcePlacement configuration                             
+19/-0   
deployment.yaml
Add deployment configuration for Nginx                                     
+25/-0   
nginx-service-eastus2euap.yaml
Add service and ServiceExport configuration for East US 2 EUAP region
+19/-0   
ro-nginx-service-eastus2euap.yaml
Add ResourceOverride configuration for East US 2 EUAP region
+34/-0   
ro-nginx-service-export-eastus2euap.yaml
Add ResourceOverride configuration for East US 2 EUAP region
+54/-0   
nginx-backend-eastus2euap.yaml
Add TrafficManagerBackend configuration for East US 2 EUAP region
+11/-0   
nginx-backend-uksouth.yaml
Add TrafficManagerBackend configuration for UK South region
+11/-0   
nginx-profile.yaml
Add TrafficManagerProfile configuration                                   
+9/-0     
placement-disruption-budget.yaml
Add ClusterResourcePlacementDisruptionBudget configuration
+6/-0     
placement-eviction-member-1.yaml
Add ClusterResourcePlacementEviction configuration for member-1
+7/-0     
placement-eviction-member-3.yaml
Add ClusterResourcePlacementEviction configuration for member-3
+7/-0     
nginx-service-uksouth.yaml
Add service and ServiceExport configuration for UK South region
+19/-0   
ro-nginx-service-export-uksouth.yaml
Add ResourceOverride configuration for UK South region     
+24/-0   
ro-nginx-service-uksouth.yaml
Add ResourceOverride configuration for UK South region     
+34/-0   
ro-nginx-service-export.yaml
Update ResourceOverride configuration for application migration
tutorial
+2/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 3, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 8deff3a)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Potential Issue
    The 'placement' field is missing in the 'ro-nginx-service-export.yaml' file. This might cause issues when applying the configuration.

    Potential Issue

    The 'placement' field is missing in the 'ro-nginx-service-uksouth.yaml' file. This might cause issues when applying the configuration.

    metadata:

    @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 3, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Specify ClusterResourcePlacement for ResourceOverride

    Add the placement field to specify the ClusterResourcePlacement.

    docs/demos/TrafficManagerProfile/testfiles/ro-nginx-service-export.yaml [3-12]

     apiVersion: placement.kubernetes-fleet.io/v1alpha1
     kind: ResourceOverride
     metadata:
       name: ro-nginx-service-export
       namespace: test-app
     spec:
    +  placement:
    +    name: crp-availability
       resourceSelectors:
         -  group: networking.fleet.azure.com
            kind: ServiceExport
            version: v1alpha1
    Suggestion importance[1-10]: 7

    __

    Why: Adding the 'placement' field enhances clarity and ensures the ResourceOverride is associated with the correct ClusterResourcePlacement.

    Medium

    Copy link
    Collaborator

    @michaelawyu michaelawyu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added a few nits, otherwise LGTM

    @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 7, 2025

    Persistent review updated to latest commit 7a612a7

    @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 7, 2025

    Persistent review updated to latest commit 8deff3a

    Copy link
    Collaborator

    @michaelawyu michaelawyu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @zhiying-lin zhiying-lin merged commit fc815f5 into Azure:main Apr 8, 2025
    7 checks passed
    @zhiying-lin zhiying-lin deleted the add-demo branch April 8, 2025 05:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants