Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Mar 7, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Expose this util so that fleet repo can use it to validate the weight annotation.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

e2e test

Special notes for your reviewer

ExtractWeightFromServiceExport does not return the User error anymore, and it will depend on the caller to wrap it. So that it can avoid the loop dep.

@zhiying-lin zhiying-lin force-pushed the expose-export-util branch 2 times, most recently from dbfb745 to 580f844 Compare March 7, 2025 06:43
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (aeabb6d) to head (af05501).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   79.94%   80.13%   +0.18%     
==========================================
  Files          28       29       +1     
  Lines        3985     3986       +1     
==========================================
+ Hits         3186     3194       +8     
+ Misses        638      631       -7     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanzhang-oss ryanzhang-oss merged commit 67022ee into Azure:main Mar 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants