-
Notifications
You must be signed in to change notification settings - Fork 19
feat: compute backend weight from serviceExport annotation #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- config/crd/bases/networking.fleet.azure.com_trafficmanagerprofiles.yaml: Evaluated as low risk
- pkg/controllers/hub/trafficmanagerbackend/controller.go: Evaluated as low risk
- pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk
7078396 to
87e3f75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 79.80% 80.03% +0.22%
==========================================
Files 28 28
Lines 3863 3926 +63
==========================================
+ Hits 3083 3142 +59
- Misses 623 628 +5
+ Partials 157 156 -1 ☔ View full report in Codecov by Sentry. |
87e3f75 to
7b048fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- go.mod: Language not supported
- pkg/controllers/hub/trafficmanagerprofile/controller.go: Evaluated as low risk
- pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
pkg/controllers/hub/trafficmanagerbackend/controller.go:437
- [nitpick] The struct name 'desiredEndpoint' is ambiguous. It should be renamed to 'DesiredEndpoint'.
type desiredEndpoint struct {
7b048fe to
4d91605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (4)
- go.mod: Language not supported
- pkg/controllers/member/serviceexport/suite_test.go: Evaluated as low risk
- pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk
- pkg/controllers/hub/trafficmanagerprofile/controller.go: Evaluated as low risk
331b2c2 to
9908894
Compare
d3aa57a to
054957d
Compare
pkg/controllers/member/serviceexport/controller_integration_test.go
Outdated
Show resolved
Hide resolved
a10825d to
d5a0eb3
Compare
zhiying-lin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the minor comments will be addressed in a separate PR, merged the code first to unblock the progress
What type of PR is this?
/kind feature
What this PR does / why we need it:
Compute ATM backend weight from the serviceExport annotation
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer