Skip to content

Conversation

@ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Feb 4, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Compute ATM backend weight from the serviceExport annotation

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@ryanzhang-oss ryanzhang-oss requested a review from Copilot February 4, 2025 08:05
@ryanzhang-oss ryanzhang-oss marked this pull request as draft February 4, 2025 08:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • config/crd/bases/networking.fleet.azure.com_trafficmanagerprofiles.yaml: Evaluated as low risk
  • pkg/controllers/hub/trafficmanagerbackend/controller.go: Evaluated as low risk
  • pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk

@ryanzhang-oss ryanzhang-oss force-pushed the compute-weight branch 2 times, most recently from 7078396 to 87e3f75 Compare February 4, 2025 23:12
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (230bcc6) to head (98f43d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/common/condition/condition.go 0.00% 11 Missing ⚠️
pkg/controllers/member/serviceexport/controller.go 94.02% 1 Missing and 3 partials ⚠️
...ontrollers/hub/trafficmanagerbackend/controller.go 92.85% 2 Missing ⚠️
...ontrollers/hub/trafficmanagerprofile/controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   79.80%   80.03%   +0.22%     
==========================================
  Files          28       28              
  Lines        3863     3926      +63     
==========================================
+ Hits         3083     3142      +59     
- Misses        623      628       +5     
+ Partials      157      156       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review February 5, 2025 00:58
@ryanzhang-oss ryanzhang-oss requested a review from Copilot February 5, 2025 02:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • go.mod: Language not supported
  • pkg/controllers/hub/trafficmanagerprofile/controller.go: Evaluated as low risk
  • pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

pkg/controllers/hub/trafficmanagerbackend/controller.go:437

  • [nitpick] The struct name 'desiredEndpoint' is ambiguous. It should be renamed to 'DesiredEndpoint'.
type desiredEndpoint struct {

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • go.mod: Language not supported
  • pkg/controllers/member/serviceexport/suite_test.go: Evaluated as low risk
  • pkg/controllers/member/serviceexport/controller.go: Evaluated as low risk
  • pkg/controllers/hub/trafficmanagerprofile/controller.go: Evaluated as low risk

Copy link
Contributor

@zhiying-lin zhiying-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the minor comments will be addressed in a separate PR, merged the code first to unblock the progress

@zhiying-lin zhiying-lin merged commit dbec29c into Azure:main Feb 10, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants