Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
validate whether the service import when handling update backend

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

integration tests

Special notes for your reviewer

updating serviceImport from invalid to valid will be tested in the future PR.

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (5fb2495) to head (b9bc9a4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ontrollers/hub/trafficmanagerbackend/controller.go 78.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   78.83%   78.71%   -0.12%     
==========================================
  Files          27       27              
  Lines        3539     3576      +37     
==========================================
+ Hits         2790     2815      +25     
- Misses        600      611      +11     
- Partials      149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiying-lin zhiying-lin merged commit 5f65940 into Azure:main Nov 7, 2024
8 of 10 checks passed
@zhiying-lin zhiying-lin deleted the trafficmanager-backend-update-3 branch November 7, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants