feat: create defaulter func for trafficManagerProfile #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 78.64% 78.68% +0.03%
==========================================
Files 22 23 +1
Lines 2210 2228 +18
==========================================
+ Hits 1738 1753 +15
- Misses 343 345 +2
- Partials 129 130 +1 ☔ View full report in Codecov by Sentry. |
jwtty
reviewed
Sep 13, 2024
jwtty
approved these changes
Sep 13, 2024
| // If no Timeout value is specified, it uses a default value of 9 seconds. | ||
| // Reference link: https://learn.microsoft.com/en-us/azure/traffic-manager/traffic-manager-monitoring#configure-endpoint-monitoring | ||
| if obj.Spec.MonitorConfig.TimeoutInSeconds == nil { | ||
| if *obj.Spec.MonitorConfig.IntervalInSeconds == 30 { |
Contributor
There was a problem hiding this comment.
what if the internal in seconds is more than 30?
Contributor
Author
There was a problem hiding this comment.
You can specify two values here: 30 seconds (normal probing) and 10 seconds (fast probing) for the intervalInSeconds.
My bad, i thought validation webhook would be invoked first. Will fix it in my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It can used by the default webhook or the profile controller.
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
add unit tests
Special notes for your reviewer