Skip to content

Conversation

@Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Aug 30, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (08bfefc) to head (e1d8525).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   78.61%   79.10%   +0.49%     
==========================================
  Files          22       24       +2     
  Lines        2899     2288     -611     
==========================================
- Hits         2279     1810     -469     
+ Misses        490      349     -141     
+ Partials      130      129       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arvindthiru
Copy link
Contributor Author

For these resources in the fleet-member namespaces there are controllers running on the hub cluster which clean up the finalizers when a delete is issued on the resources so we can ignore these resources when MC needs to be force deleted

EndpointSliceExport - https://github.com/Azure/fleet-networking/blob/main/pkg/controllers/hub/endpointsliceexport/controller.go#L334

InternalServiceImport - https://github.com/Azure/fleet-networking/blob/main/pkg/controllers/hub/internalserviceimport/controller.go#L264

InternalServiceExport - https://github.com/Azure/fleet-networking/blob/main/pkg/controllers/hub/internalserviceexport/controller.go#L119

@Arvindthiru Arvindthiru marked this pull request as ready for review September 6, 2024 20:22
@Arvindthiru
Copy link
Contributor Author

Arvindthiru commented Sep 16, 2024

Based on re-sync period configured objects are re-listed and OnUpdate is called,

Informer interface with ResourceEventHandler: https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/cache/cache.go#L113
ResourceEventHandler OnUpdate https://github.com/kubernetes/client-go/blob/master/tools/cache/controller.go#L214-L219

We might need to set a re-sync period for this particular controller to account for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants