Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • heartbeat will fail when multiple agents update the imc at the same time.Thus, adding jitter to reduce the conflict possibility.
  • Update mcs condition message to cover mcs won't work if service has been exported by other mcs.
  • Use api machinery rand package to generate random number instead of using two packages.

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #129 (4ba81ad) into main (d72c3d2) will decrease coverage by 1.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   79.14%   77.93%   -1.22%     
==========================================
  Files          20       20              
  Lines        2455     2456       +1     
==========================================
- Hits         1943     1914      -29     
- Misses        400      426      +26     
- Partials      112      116       +4     
Impacted Files Coverage Δ
pkg/common/uniquename/uniquename.go 82.96% <ø> (-0.25%) ⬇️
...rollers/member/internalmembercluster/controller.go 71.52% <100.00%> (+0.57%) ⬆️
pkg/controllers/multiclusterservice/controller.go 84.24% <100.00%> (ø)
...rollers/member/internalserviceexport/controller.go 75.00% <0.00%> (-8.34%) ⬇️
...ontrollers/hub/internalserviceimport/controller.go 76.30% <0.00%> (-4.02%) ⬇️
...ntrollers/member/endpointsliceimport/controller.go 73.48% <0.00%> (-3.32%) ⬇️
.../controllers/hub/endpointsliceexport/controller.go 70.18% <0.00%> (-3.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiying-lin zhiying-lin merged commit d118c60 into Azure:main Sep 29, 2022
@zhiying-lin zhiying-lin deleted the jitter branch September 29, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants