Skip to content

Use persistent HTTP client to speed up requests #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinjiang merged 2 commits into from
Aug 27, 2020
Merged

Use persistent HTTP client to speed up requests #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa1156
Use persistent HTTP client to speed up requests
JelteF Jul 14, 2020
5d4b076
Add net-http-persistent dependency to gemspec as well
JelteF Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
source "https://rubygems.org" do
gem "faraday", "~> 1.0", :require => false
gem "faraday_middleware", "~> 1.0.0.rc1", :require => false
gem "net-http-persistent", "~> 4.0", :require => false
gem "nokogiri", "~> 1.10.4", :require => false

gem "adal", "~> 1.0", :require => false
Expand Down
1 change: 1 addition & 0 deletions common/azure-storage-common.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Gem::Specification.new do |s|

s.add_runtime_dependency('faraday', '~> 1.0')
s.add_runtime_dependency('faraday_middleware', '~> 1.0.0.rc1')
s.add_runtime_dependency("net-http-persistent", '~> 4.0')
s.add_runtime_dependency("nokogiri", "~> 1.10.4")

s.add_development_dependency("dotenv", "~> 2.0")
Expand Down
5 changes: 4 additions & 1 deletion common/lib/azure/storage/common/core/http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ def build_http(uri)
end || nil
Faraday.new(uri, ssl: ssl_options, proxy: proxy_options) do |conn|
conn.use FaradayMiddleware::FollowRedirects
conn.adapter Faraday.default_adapter
conn.adapter :net_http_persistent, pool_size: 5 do |http|
# yields Net::HTTP::Persistent
http.idle_timeout = 100
end
end
end
end
Expand Down