Skip to content

Fixed design flaw for get_blob_to_* and get_file_to_* methods when max_connections is 1#473

Merged
zezha-msft merged 1 commit into
Azure:devfrom
zezha-msft:single-thread-download
Jul 11, 2018
Merged

Fixed design flaw for get_blob_to_* and get_file_to_* methods when max_connections is 1#473
zezha-msft merged 1 commit into
Azure:devfrom
zezha-msft:single-thread-download

Conversation

@zezha-msft

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Jul 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #473 into dev will increase coverage by 0.89%.
The diff coverage is 69.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #473      +/-   ##
==========================================
+ Coverage   86.15%   87.05%   +0.89%     
==========================================
  Files          57       57              
  Lines        4565     4604      +39     
  Branches      495      500       +5     
==========================================
+ Hits         3933     4008      +75     
+ Misses        476      436      -40     
- Partials      156      160       +4
Impacted Files Coverage Δ
...zure-storage-common/azure/storage/common/_error.py 89% <ø> (-0.11%) ⬇️
...rage-file/azure/storage/file/_download_chunking.py 73.61% <51.35%> (+55.42%) ⬆️
...rage-blob/azure/storage/blob/_download_chunking.py 85.89% <72.22%> (+25.24%) ⬆️
...ure-storage-file/azure/storage/file/fileservice.py 92.79% <76.92%> (+0.77%) ⬆️
...storage-blob/azure/storage/blob/baseblobservice.py 94.06% <83.33%> (-0.8%) ⬇️
...ure-storage-blob/azure/storage/blob/_encryption.py 90.24% <0%> (-3.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86eec8b...8f68597. Read the comment docs.

@zezha-msft zezha-msft merged commit ecc7d73 into Azure:dev Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants