Skip to content

Conversation

v-dharmarajv
Copy link
Member

Removed files which are not released on the ga5 these are from the implementation folder. In other languages this will be deleted using the autorest whereas in java we have to manually delete. In last check-in when tried to ga5 to main missed these. This will not cause any issues or any changes on the apiview.

@Copilot Copilot AI review requested due to automatic review settings July 11, 2025 19:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR manually removes implementation files related to dialog models and service operations that are not part of the GA5 release, and updates test utilities and configuration to reflect those deletions.

  • Deleted unused dialog-related implementation models and the CallDialogsImpl service class.
  • Cleaned up test base by removing dialog-specific imports, constants, and helper methods.
  • Updated swagger README directives, SpotBugs excludes, and Checkstyle suppressions to remove entries for deleted classes.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/communication/azure-communication-callautomation/swagger/README.md Removed obsolete dialog rename/remove directives
sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallAutomationUnitTestBase.java Removed DialogStateResponse import, DIALOG_ID constant, and helper
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/UpdateDialogRequest.java Deleted unused dialog update request model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/StartDialogRequestInternal.java Deleted unused start dialog request model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/PowerVirtualAgentsDialog.java Deleted unused PowerVirtualAgentsDialog model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/DialogUpdated.java Deleted unused DialogUpdated model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/DialogUpdateBase.java Deleted unused base class for dialog updates
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/DialogStateResponse.java Deleted unused dialog state response model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/DialogInputType.java Deleted unused dialog input type enum
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/BaseDialog.java Deleted unused BaseDialog model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/AzureOpenAIDialogUpdate.java Deleted unused AzureOpenAIDialogUpdate model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/models/AzureOpenAIDialog.java Deleted unused AzureOpenAIDialog model
sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/implementation/CallDialogsImpl.java Deleted entire CallDialogsImpl service implementation
sdk/communication/azure-communication-callautomation/spotbugs-exclude.xml Removed SpotBugs excludes for deleted dialog classes
sdk/communication/azure-communication-callautomation/checkstyle-suppressions.xml Removed Checkstyle suppressions for deleted dialog-related files
Comments suppressed due to low confidence (3)

sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallAutomationUnitTestBase.java:22

  • Tests still referencing DialogStateResponse will fail to compile now that the model is deleted; update or remove those references in your tests.
import com.azure.communication.callautomation.implementation.models.GetParticipantsResponseInternal;

sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallAutomationUnitTestBase.java:57

  • The DIALOG_ID constant was removed, so tests referencing it need to be updated—either reintroduce an appropriate value or inline the literal where needed.
    static final String CALL_OPERATION_CONTEXT = "operationContext";

@v-dharmarajv v-dharmarajv merged commit dbfb267 into main Jul 14, 2025
17 checks passed
@v-dharmarajv v-dharmarajv deleted the users/v-dharmarajv/removingUnusedFiles branch July 14, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants