Skip to content

Rename API for get/setPreferredLocations and get/setUseMultipleWriteLocations #10680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

Rename API for get/setPreferredLocations and get/setUseMultipleWriteLocations #10680

merged 2 commits into from
May 4, 2020

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented May 2, 2020 •
edited by kushagraThapar
Loading

  1. Rename get/setPreferredLocations -> get/setPreferredRegions
  2. Rename get/setUseMultipleWriteLocations -> get/setUseMultipleWriteRegions

This issue addresses : #8271

moderakh
moderakh approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congratulate on your first PR Annie.
Awesome work. Looks good to me.

kushagraThapar
kushagraThapar approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @xinlian12
LGTM!

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12 xinlian12 merged commit eb71fce into Azure:master May 4, 2020
@hemanttanwar hemanttanwar mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@David-Noble-at-work David-Noble-at-work Awaiting requested review from David-Noble-at-work

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

+1 more reviewer

@moderakh moderakh moderakh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinlian12 @mitchdenny @kushagraThapar @moderakh