[Migration-Check]sdk/resourcemanager/resources/policy #25804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the sdk/resourcemanager/resources/armpolicy module from AutoRest to the Microsoft Go Code Generator, updating the API version from 2023-04-01 to 2025-03-01.
Key Changes:
- Removes deprecated Variable and VariableValue clients (preview API features)
- Adds new Tokens client for policy token acquisition
- Updates all code generation comments and copyright headers
- Restructures parameter definitions to use wrapper types with AdditionalProperties
- Removes several response types for deleted clients
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.go | New file defining module name and version (v1.0.0) |
| tokens_client.go | New client for acquiring policy tokens at subscription and management group levels |
| tokens_client_example_test.go | Examples for the new Tokens client operations |
| setdefinitions_client.go | Updated with new code generator, API version 2025-03-01, improved documentation |
| setdefinitions_client_example_test.go | Updated examples with new parameter structure using AdditionalProperties |
| setdefinitionversions_client.go | Updated with new code generator and API version 2025-03-01 |
| setdefinitionversions_client_example_test.go | Updated examples with restructured parameter types |
| responses.go | Removed response types for deleted Variable/VariableValue/DataPolicyManifest clients |
| variables_client.go | Deleted - preview feature removed |
| variablevalues_client.go | Deleted - preview feature removed |
| time_rfc3339.go | Updated code generation comment |
| tsp-location.yaml | New file specifying TypeSpec source location |
| testdata/_metadata.json | New metadata file for API version 2025-03-01 |
| fake/internal.go | Updated code generation comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate base on branchtsp-convertion_resources-policy