add initializer for device props #2392
Conversation
danewalton-msft
requested review from
CIPop,
ericwolz,
ewertons,
JoseSanchez7,
jspaith,
preethi826,
RLeclair and
vaavva
as code owners
| adu_device_properties.manufacturer = AZ_SPAN_FROM_STR(TEST_ADU_DEVICE_MANUFACTURER); | ||
| adu_device_properties.model = AZ_SPAN_FROM_STR(TEST_ADU_DEVICE_MODEL); | ||
| adu_device_properties.adu_version = AZ_SPAN_FROM_STR(TEST_AZ_IOT_ADU_CLIENT_AGENT_VERSION); | ||
| adu_device_properties.delivery_optimization_agent_version = AZ_SPAN_EMPTY; |
There was a problem hiding this comment.
Should this be AZ_SPAN_LITERAL_EMPTY? Looks like that's what it used to be and what we set it to in the device_properties_default
There was a problem hiding this comment.
The _LITERAL variants of span initializers are used for setting values in struct literals. So anything with some
my_struct = { .myvalue = blah };kind of initialization.
For assigning individual values of a struct, we can set using the non-literal version which adds a cast to that value.
danewalton-msft
requested review from
ahsonkhan,
antkmsft,
RickWinter,
vhvb1989 and
gearama
as code owners
This reverts commit 20504b4.
| * | ||
| * @return #az_iot_adu_client_device_properties. | ||
| */ | ||
| AZ_NODISCARD az_iot_adu_client_device_properties az_iot_adu_client_device_properties_default(); |
There was a problem hiding this comment.
Nit - since this is not an "options" it should be named az_iot_adu_client_device_properties_init similar to az_iot_message_properties_init.
There was a problem hiding this comment.
I think here it should be _default(). The _init() is used to initialize a struct with parameters/values which from then on become private fields of the initialized struct. The interactions on that initialized struct are more or less as though it were an object.
Here, we're giving people a preconfigured default struct which they then directly act on. Thoughts?
No description provided.