-
Notifications
You must be signed in to change notification settings - Fork 4k
[Az.Migrate] Bug fixes related to disk validations #28309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
3e5a926
to
b7bb89a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the New-AzMigrateLocalDiskMappingObject
function where the validation logic for PhysicalSectorSize
was incorrectly triggering when the parameter wasn't explicitly provided by the user.
- Modified validation logic to only check
PhysicalSectorSize
when explicitly provided - Enhanced error message to include the actual value that was provided
- Added parameter existence check using
$PSBoundParameters.ContainsKey()
src/Migrate/Migrate.Autorest/custom/New-AzMigrateLocalDiskMappingObject.ps1
Show resolved
Hide resolved
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @minhsuanlee, please update the Changelog accordingly. And I also wondering if this need a test case |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
89517c7
to
f08893a
Compare
I've updated the Changelog. As for test case, we are testing PS module change with our dev test pipelines. I will keep the DoNotMerge tag for now but please continue with the review. Thank you. |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
@minhsuanlee can I ask why the |
Yes, and also we may push more changes if new bugs come up before Code Complete for this iteration. |
@minhsuanlee Please keep me updated if you have other updates. Or you can choose to merge this first and raise another PR for further review & merge |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.