Spelling Fixes #28066
Open
Spelling Fixes #28066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR is focused exclusively on spelling fixes in comments, displayable strings, error messages, and documentation across various files in the codebase. The key changes include corrections to typos in error messages and help texts in PowerShell and C# files, as well as updates in the changelog and markdown examples.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/NetworkSecurityPerimeter.Autorest/test/utils.ps1 | Corrected typos ("occcured" → "occured") in error messages. |
| src/Network/NetworkSecurityPerimeter.Autorest/examples/Get-AzNetworkSecurityPerimeterLoggingConfiguration.md | Fixed spelling inconsistencies in the heading and text. |
| src/Network/NetworkSecurityPerimeter.Autorest/docs/Get-AzNetworkSecurityPerimeterLoggingConfiguration.md | Updated spelling in example headers and descriptions. |
| src/Network/NetworkSecurityPerimeter.Autorest/custom/Update-AzNetworkSecurityPerimeterLoggingConfiguration.ps1 | Fixed spelling errors in comments (e.g. "paramters" → "parameters"). |
| src/Network/NetworkSecurityPerimeter.Autorest/custom/Update-AzNetworkSecurityPerimeterLink.ps1 | Corrected typos in comments. |
| src/Network/NetworkSecurityPerimeter.Autorest/custom/Update-AzNetworkSecurityPerimeterAssociation.ps1 | Corrected spelling in comments. |
| src/Network/NetworkSecurityPerimeter.Autorest/custom/Update-AzNetworkSecurityPerimeterAccessRule.ps1 | Fixed spelling in comments. |
| src/Network/Network.Test/ScenarioTests/VirtualRouterTests.ps1 | Updated comments to fix typos ("advertiesd" → "advertised"). |
| src/Network/Network.Test/ScenarioTests/PublicIpAddressTests.ps1 | Corrected multiple occurrences of "publicIpAddres" to "public IpAddress". |
| src/Network/Network.Test/ScenarioTests/PrivateLinkServiceTests.ps1 | Fixed a typo in the comment ("Verfify" → "Verify"). |
| src/Network/Network.Test/ScenarioTests/PrivateEndpointTests.ps1 | Corrected spelling errors in comments ("Verfify" → "Verify"). |
| src/Network/Network.Test/ScenarioTests/NetworkSecurityGroupTests.ps1 | Updated descriptions by correcting typos in spelling ("desciption" → "description"). |
| src/Network/Network.Test/ScenarioTests/NetworkManagerTests.ps1 | Fixed a typo in a comment ("runing" → "running"). |
| src/Network/Network.Test/ScenarioTests/MultiIpConfigOnNicTests.ps1 | Corrected typos in comments ("accociate" → "associate", "muultiple" → "multiple"). |
| src/Network/Network.Test/ScenarioTests/AzureFirewallPolicyTests.ps1 | Fixed spelling mistakes in comments ("TerminatTLS" → "TerminateTLS"). |
| src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1 | Corrected typos in comments ("emtpy" → "empty", "rotuing" → "routing"). |
| src/NetAppFiles/NetAppFiles/VolumeGroup/NewNetAppFilesVolumeGroup.cs | Fixed spelling in inline comments ("compliler" → "compiler"). |
| src/NetAppFiles/NetAppFiles/Volume/NewAzureNetAppFilesExportPolicyObject.cs | Updated spelling in the help message ("endpont" → "endpoint"). |
| src/NetAppFiles/NetAppFiles/SnapshotPolicy/UpdateNetAppFilesSnapshotPolicy.cs | Corrected spelling in help messages ("montly" → "monthly"). |
| src/NetAppFiles/NetAppFiles/SnapshotPolicy/SetNetAppFilesSnapshotPolicy.cs | Updated help messages to fix spelling errors ("montly" → "monthly"). |
| src/NetAppFiles/NetAppFiles/SnapshotPolicy/NewNetAppFilesSnapshotPolicy.cs | Fixed spelling in help messages ("montly" → "monthly"). |
| src/NetAppFiles/NetAppFiles/Models/PSNetAppFilesActiveDirectory.cs | Corrected a typo in a code comment ("drectory" → "directory"). |
| src/NetAppFiles/NetAppFiles/ChangeLog.md | Fixed spelling errors in changelog entries (e.g. "requred" → "required", "paramter" → "parameter", "convetion" → "convention"). |
| src/NetAppFiles/NetAppFiles/ActiveDirectory/UpdateNetAppFilesActiveDirectory.cs | Corrected a typo in an exception message ("extist" → "exist"). |
| src/NetAppFiles/NetAppFiles/ActiveDirectory/NewNetAppFilesActiveDirectory.cs | Corrected a typo in an exception message ("extist" → "exist"). |
|
Thank you for your contribution @ArieHein! We will review the pull request and get back to you soon. |
YanaXu
previously approved these changes
Jul 1, 2025
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
reviewed
Jul 1, 2025
| @@ -154,7 +154,7 @@ function Test-NetworkSecurityGroup-SecurityRuleCRUD | |||
| $resourceGroup = New-AzResourceGroup -Name $rgname -Location $rglocation -Tags @{ testtag = "testval" } | |||
|
|
|||
| # Create SecurityRule | |||
| $securityRule = New-AzNetworkSecurityRuleConfig -Name $securityRule1Name -Description "desciption" -Protocol Tcp -SourcePortRange "23-45" -DestinationPortRange "46-56" -SourceAddressPrefix * -DestinationAddressPrefix * -Access Allow -Priority 123 -Direction Inbound | |||
There was a problem hiding this comment.
Not all "desciption" are replaced. The change is not necessary. The tests will be failed.
azure-powershell\src\Network\Network.Test\SessionRecords\Commands.Network.Test.ScenarioTests.NetworkSecurityGroupTests> (ls | sls desciption).Path | Sort-Object -Unique | Resolve-Path -Relative
.\TestNetworkSecurityGroupMultiValuedRules.json
.\TestNetworkSecurityGroupSecurityRuleCRUD.json
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
Hi @ArieHein, I suggest you to revert the change in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This does spelling fixes in codebase files that are either:
in comments.
in displayable strings.
There are NO other changes to programmatic aspects or code behavior.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.