-
Notifications
You must be signed in to change notification settings - Fork 4k
Spelling Fixes #28051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling Fixes #28051
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Thank you for your contribution @ArieHein! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes various spelling mistakes across resource files, commandlets, changelogs, and documentation to improve clarity in displayable strings and comments.
- Corrects typos in resource messages (e.g., "ConsumerGrop", "Removeing", "AtuhorizationRule", "Deleteing").
- Fixes spelling errors in parameter messages, changelog entries, and documentation (e.g., "cmmdlet", "hastable", "appplication", "CleaupPolicy", "vaule1").
Reviewed Changes
Copilot reviewed 11 out of 35 changed files in this pull request and generated 18 comments.
Show a summary per file
File | Description |
---|---|
src/EventHub/EventHub/Resources.resx | Fixed multiple spelling errors in resource values. |
src/EventHub/EventHub/Cmdlets/AuthorizationRule/NewAzureEventhubAuthorizationRuleSASToken.cs | Corrected typo in parameter help message. |
src/EventHub/EventHub/ChangeLog.md | Fixed spelling mistake in the changelog entry. |
src/EventHub/EventHub.Autorest/examples/Set-AzEventHubNamespace.md | Corrected spelling of “hashtable” in example text. |
src/EventHub/EventHub.Autorest/examples/Set-AzEventHubApplicationGroup.md | Fixed spelling error in description of application group policies. |
src/EventHub/EventHub.Autorest/examples/New-AzEventHub.md | Corrected “CleaupPolicy” to “CleanupPolicy” in examples. |
src/EventHub/EventHub.Autorest/docs/Set-AzEventHubNamespace.md | Fixed spelling of “hashtable” in documentation. |
src/EventHub/EventHub.Autorest/docs/Set-AzEventHubApplicationGroup.md | Corrected spelling of “application” in documentation. |
src/EventHub/EventHub.Autorest/docs/New-AzEventHub.md | Corrected “CleaupPolicy” to “CleanupPolicy” in documentation. |
src/EventGrid/EventGrid.Autorest/examples/New-AzEventGridDynamicRoutingEnrichmentObject.md | Corrected spelling of “vaule1” to “value1” in example usage and output. |
src/EventGrid/EventGrid.Autorest/docs/New-AzEventGridDynamicRoutingEnrichmentObject.md | Corrected spelling of “vaule1” to “value1” in documentation. |
Files not reviewed (1)
- src/EventHub/EventHub/Resources.Designer.cs: Language not supported
@@ -187,19 +187,19 @@ | |||
<value>Reject PrivateEndpoint named: {0} for Namespace: {1} of ResourceGroup: {2}</value> | |||
</data> | |||
<data name="RemoveConsumerGroup" xml:space="preserve"> | |||
<value>Deleting ConsumerGrop:{0} from Eventhub:{1}</value> | |||
<value>Deleting ConsumerGroup:{0} from Eventhub:{1}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'ConsumerGrop' to 'ConsumerGroup'.
Copilot uses AI. Check for mistakes.
</data> | ||
<data name="RemoveEventHubAuthorizationRule" xml:space="preserve"> | ||
<value>Removeing AtuhorizationRule:{0} from EventHub:{1} of Namespace: {2}</value> | ||
<value>Removing AuthorizationRule:{0} from EventHub:{1} of Namespace: {2}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling errors: updated 'Removeing' to 'Removing' and 'AtuhorizationRule' to 'AuthorizationRule'.
Copilot uses AI. Check for mistakes.
</data> | ||
<data name="RemoveEventhubcluster" xml:space="preserve"> | ||
<value>Deleteing Eventhub Cluster {1} from ResourceGroup {0}</value> | ||
<value>Deleting Eventhub Cluster {1} from ResourceGroup {0}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'Deleteing' to 'Deleting'.
Copilot uses AI. Check for mistakes.
</data> | ||
<data name="RemoveEventHubSchemaGroup" xml:space="preserve"> | ||
<value>Removing Schema Group named:{0} of Namespace: {1}</value> | ||
</data> | ||
<data name="RemoveNamespaceAuthorizationRule" xml:space="preserve"> | ||
<value>Removing AtuhorizationRule:{0} of Namespace: {1}</value> | ||
<value>Removing AuthorizationRule:{0} of Namespace: {1}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'AtuhorizationRule' to 'AuthorizationRule'.
Copilot uses AI. Check for mistakes.
@@ -30,7 +30,7 @@ namespace Microsoft.Azure.Commands.EventHub.Commands | |||
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "EventHubAuthorizationRuleSASToken", DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(PSSharedAccessSignatureAttributes))] | |||
public class NewAzureAuthorizationRuleSASToken : AzureEventHubsCmdletBase | |||
{ | |||
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, Position = 0, HelpMessage = "ARM ResourceId of the Authoraization Rule")] | |||
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, Position = 0, HelpMessage = "ARM ResourceId of the Authorization Rule")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'Authoraization' to 'Authorization' in the HelpMessage.
Copilot uses AI. Check for mistakes.
@@ -158,7 +158,7 @@ Type : Microsoft.EventHub/namespaces/eventhubs | |||
UpdatedAt : 4/25/2023 4:05:58 AM | |||
``` | |||
|
|||
Creates a new eventhub entity `myEventHub` on namespace `myNamespace` with CleaupPolicy `Compact`. | |||
Creates a new eventhub entity `myEventHub` on namespace `myNamespace` with CleanupPolicy `Compact`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'CleaupPolicy' to 'CleanupPolicy' in the Compact example.
Copilot uses AI. Check for mistakes.
@@ -1,12 +1,12 @@ | |||
### Example 1: Create an in-memory object for DynamicRoutingEnrichment. | |||
```powershell | |||
New-AzEventGridDynamicRoutingEnrichmentObject -Key key1 -Value vaule1 | |||
New-AzEventGridDynamicRoutingEnrichmentObject -Key key1 -Value value1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'vaule1' to 'value1' in the command usage.
Copilot uses AI. Check for mistakes.
``` | ||
|
||
```output | ||
Key Value | ||
--- ----- | ||
key1 vaule1 | ||
key1 value1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'vaule1' to 'value1' in the output.
Copilot uses AI. Check for mistakes.
@@ -23,13 +23,13 @@ Create an in-memory object for DynamicRoutingEnrichment. | |||
|
|||
### Example 1: Create an in-memory object for DynamicRoutingEnrichment. | |||
```powershell | |||
New-AzEventGridDynamicRoutingEnrichmentObject -Key key1 -Value vaule1 | |||
New-AzEventGridDynamicRoutingEnrichmentObject -Key key1 -Value value1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'vaule1' to 'value1' in the command usage.
Copilot uses AI. Check for mistakes.
``` | ||
|
||
```output | ||
Key Value | ||
--- ----- | ||
key1 vaule1 | ||
key1 value1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling: changed 'vaule1' to 'value1' in the output.
Copilot uses AI. Check for mistakes.
@@ -20,7 +20,7 @@ Location : eastus | |||
MessageRetentionInDay : 7 | |||
Name : myEventHub | |||
PartitionCount : 5 | |||
PartitionId : {0, 1, 2, 3�} | |||
PartitionId : {0, 1, 2, 3�} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this char.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is very wierd. I think my VS didnt like the original character. Reverted.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Head branch was pushed to by a user without write access
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This does spelling fixes in codebase files that are either:
in comments.
in displayable strings.
There are NO other changes to programmatic aspects or code behavior.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.