Skip to content

adding missing Name flag - line 29 #25835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024
Merged

adding missing Name flag - line 29 #25835

merged 1 commit into from
Aug 16, 2024

Conversation

duongau
Copy link
Contributor

@duongau duongau commented Aug 15, 2024

Description

The command for Get-AzPublicIPAddress on line 29 needs the Name in order to run properly.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Aug 15, 2024

️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution duongau! We will review the pull request and get back to you soon.

@duongau
Copy link
Contributor Author

duongau commented Aug 15, 2024

Creating PR to resolve this GitHub issue raised by support: #25661.

@dolauli dolauli self-assigned this Aug 16, 2024
@dolauli
Copy link
Contributor

dolauli commented Aug 16, 2024

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dolauli dolauli merged commit 0891055 into Azure:main Aug 16, 2024
12 of 13 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
@duongau duongau deleted the patch-1 branch August 16, 2024 16:48
VeryEarly added a commit that referenced this pull request Aug 19, 2024
@duongau
Copy link
Contributor Author

duongau commented Aug 27, 2024

Hi @dolauli and @VeryEarly, I just wanted to follow up and see how long does it take for this change to reflect live? I see the changes have been merged into GitHub but on the live side it hasn't been reflected yet.

@Ravi2305 for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants