Skip to content

[Az.RecoveryServices.Backup] Archive preview release #14413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Mar 3, 2021

Description

Archive public preview release targeted 08th March, 21. This PR is to be merged to preview branch Az.RecoveryServices-preview

Checklist

  • [Yes] I have read the Submitting Changes section of CONTRIBUTING.md
  • [Yes] The title of the PR is clear and informative
  • [Yes] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [Yes] The PR does not introduce breaking changes
  • [N/A] If applicable, the changes made in the PR have proper test coverage
  • [Yes] For public API changes to cmdlets:

@hiaga hiaga force-pushed the archive-preview branch from 8695994 to 0502a22 Compare March 3, 2021 08:53
@hiaga hiaga requested a review from sambitratha March 3, 2021 08:54
@wyunchi-ms
Copy link
Contributor

Please fix the analysis issue and test issues?

@hiaga hiaga force-pushed the archive-preview branch from 0502a22 to 006fbd3 Compare March 5, 2021 11:35
@hiaga
Copy link
Member Author

hiaga commented Mar 5, 2021

Hi @wyunchi-ms, re-recording the tests and fixing the PR issues.

@hiaga hiaga self-assigned this Mar 5, 2021
@hiaga hiaga force-pushed the archive-preview branch from 006fbd3 to e8c83d3 Compare March 6, 2021 14:07
@hiaga
Copy link
Member Author

hiaga commented Mar 6, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@hiaga
Copy link
Member Author

hiaga commented Mar 6, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@hiaga
Copy link
Member Author

hiaga commented Mar 6, 2021

@wyunchi-ms can you pls check if something is wrong with pipeline. Build is passing in my local machine and was passing in my previous run.

@isra-fel
Copy link
Member

isra-fel commented Mar 8, 2021

OK I got it.
We removed an invalid nuget feed in Jan, but your target branch Az.RecoveryServices-preview is kind of out-of-sync with master, so you got the build error when msbuild tried to access that invalid feed.

Please submit another PR to sync the preview branch. Then this one should be unblocked.

@isra-fel
Copy link
Member

isra-fel commented Mar 8, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@hiaga
Copy link
Member Author

hiaga commented Mar 8, 2021

@isra-fel : created another PR for sync preview branch: #14462. Pls review

@hiaga hiaga force-pushed the archive-preview branch from e8c83d3 to 0904a12 Compare March 8, 2021 05:57
@hiaga
Copy link
Member Author

hiaga commented Mar 8, 2021

rebasing with #14462

re-record tests

adding help text

rebasing with preview branch

fixing help generation
@hiaga hiaga force-pushed the archive-preview branch from 0904a12 to b4ad702 Compare March 8, 2021 07:42
@wyunchi-ms wyunchi-ms merged commit 69968da into Azure:Az.RecoveryServices-preview Mar 8, 2021
hiaga added a commit to MabOneSdk/azure-powershell that referenced this pull request May 27, 2021
re-record tests

adding help text

rebasing with preview branch

fixing help generation

cherry-pick Archive
msJinLei pushed a commit to msJinLei/azure-powershell that referenced this pull request May 31, 2021
re-record tests

adding help text

rebasing with preview branch

fixing help generation
hiaga added a commit to MabOneSdk/azure-powershell that referenced this pull request Jun 1, 2021
re-record tests

adding help text

rebasing with preview branch

fixing help generation

cherry-pick Archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants