Skip to content

Fix keda templates & namespace config #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jul 31, 2025

Issue describing the changes in this PR

resolves #1883

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

When running func kubernetes install --namespace myns for V2, the namespace value is ignored the templates do not have KEDA_NAMESPACE string to replace. I've updated the V2 templates to replace the default namespaces with KEDA_NAMESPACE so that we do actually take the namespace into account. Instead we now programmatically set the default value is the namespace is not provided.

I also found that when a namespace is not provided, we still return "true" on CreateNamespace without actually checking if a default namespace exists. This results in the action failing if we do not provide a namespace and the "default" namespace does not exist. Fixed this by checking for the config namespace, and if not set, we provide a default namespace value instead of leaving namespace as null.

@liliankasem liliankasem marked this pull request as ready for review July 31, 2025 20:55
@liliankasem liliankasem requested a review from a team as a code owner July 31, 2025 20:55
@liliankasem liliankasem changed the title Fix keda templates Fix keda templates & namespace config Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Deploying KEDA on AKS Using Azure Functions Core Tools
3 participants