Skip to content

Default to .NET 8 for inproc #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jul 30, 2025

Issue describing the changes in this PR

resolves #4215

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • I have added all required tests (Unit tests, E2E tests)

@liliankasem liliankasem requested a review from a team as a code owner July 30, 2025 23:49
@jviau
Copy link
Contributor

jviau commented Jul 31, 2025

For the end to end experience, net8 in-proc apps need an extra app setting when deployed to Azure. Is that end to end experience covered here? Or will customer's need to just know that add that setting themselves?

@liliankasem
Copy link
Member Author

For the end to end experience, net8 in-proc apps need an extra app setting when deployed to Azure. Is that end to end experience covered here? Or will customer's need to just know that add that setting themselves?

I'm not actually sure about the Azure experience, but FUNCTIONS_INPROC_NET8_ENABLED is only required for Core Tools IIRC (and that is set automatically via the .NET 8 template) - or are you referring to a different setting?

@jviau
Copy link
Contributor

jviau commented Jul 31, 2025

I think FUNCTIONS_INPROC_NET8_ENABLED is needed in Azure also, so that we deploy you to a net8 host and not a net6 host (as their site extensions are different). But if the template adds that setting it sounds good to me

@liliankasem liliankasem merged commit 37e031e into main Jul 31, 2025
33 checks passed
@liliankasem liliankasem deleted the liliankasem/inproc-defaults-to-net8 branch July 31, 2025 20:54
@satvu
Copy link
Member

satvu commented Jul 31, 2025

Templates suggest it: https://github.com/Azure/azure-functions-templates/blob/dev/Functions.Templates/ProjectTemplate_v4.x/CSharp/local.settings.json (inside local.settings.json) and it's documented here. I think it would be good to test deploying and making sure the proper host is used in Azure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Function Core Tools incorrectly default to .NET 6 when creating an in-process Function
3 participants