-
Notifications
You must be signed in to change notification settings - Fork 458
Handling Functions Runtime Environment env var when set by user #4535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/Azure.Functions.Cli.Tests/ActionsTests/StartHostActionTests.cs
Outdated
Show resolved
Hide resolved
adf6ec8
to
78bd207
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
78bd207
to
40e9b26
Compare
@@ -300,7 +300,7 @@ private async Task<IDictionary<string, string>> GetConfigurationSettings(string | |||
|
|||
// when running locally in CLI we want the host to run in debug mode | |||
// which optimizes host responsiveness | |||
settings.Add("AZURE_FUNCTIONS_ENVIRONMENT", "Development"); | |||
settings.TryAdd("AZURE_FUNCTIONS_ENVIRONMENT", "Development"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of side effects if we allow for this to be overridden. The WebJobs SDK and host behaviors for polling intervals, logging, and other things will change, and this could significantly impact the local debugging experience in surprising ways.
Closing in favor of #4563 |
with accompanying test
Fixes #2465
Issue describing the changes in this PR
resolves #2465
Pull request checklist
release_notes.md