Fixing core tools host #4417
Merged
Fixing core tools host #4417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishwaryabh
force-pushed
the
aibhandari/fix-coretoolshost-real
branch
2 times, most recently
from
b648eca to
bface4f
Compare
aishwaryabh
force-pushed
the
aibhandari/fix-coretoolshost-real
branch
from
a04133b to
41f15d7
Compare
liliankasem
approved these changes
May 13, 2025
satvu
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR broke the core-tools-host by changing the style of the
GetHostFXRPathmethod. The nethost library expects the method to be calledget_hostfxr_pathbut due to the style constraints, we need to add an entry point to specify that is the expected method. Otherwise the VS e2e tests fail in the consolidated pipeline since the host cannot be loaded.This regression wasn't caught earlier because the path for which the core-tools-host pipeline runs was incorrect. This PR also fixes that and ensures that the consolidated pipeline automatically selects the build from the main branch to avoid regressions like this.
Pull request checklist