Remove inherited base policies on custom policy #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the inbound block, the default base policy (allowed-methods GET, POST, PUT and allowed-origins wildcard) was overriding the custom policies defiled here. Assuming the same undesired effect could happen on the outbound and error blocks.
|
Thanks @blgo for the change. These template repos are generated/sync'ed and the actual changes have to be done here - https://github.com/Azure/azure-dev @hemarina can you take this change and test it with our pipelines? |
This was referenced Jun 1, 2023
|
@blgo Thanks for bring this up. Could we follow up in issue Azure/azure-dev#2347 on more details in your situation and work out together to a solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the inbound block, the default base policy (allowed-methods GET, POST, PUT and allowed-origins wildcard) was overriding the custom policies defiled here.
Assuming the same undesired effect could happen on the outbound and error blocks.