feature: add login sound functionality and settings entry#2155
Open
RaiHormo wants to merge 3 commits intoAvengeMedia:masterfrom
Open
feature: add login sound functionality and settings entry#2155RaiHormo wants to merge 3 commits intoAvengeMedia:masterfrom
RaiHormo wants to merge 3 commits intoAvengeMedia:masterfrom
Conversation
Collaborator
|
Thanks, this looks good overall! One request, keep it off by default. |
Contributor
Author
Alright, I can do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1838
The login sound will play half a second after DMS starts. It worked with smaller delays, but I'm just being safe.
I have added a new settings entry, but not any translations for it.
I've also added a now-deprecated desktop-login sound from the XDG sound theme as a fallback. I want feedback of whether this should be included or not.