Conversation
fix close dialog bug when `IsMultipleDialogsEnabled=true`
| ///// <summary>Close a modal dialog.</summary> | ||
| ///// <param name="dialogIdentifier">of the instance where the dialog should be closed. Typically this will match an identifier set in XAML.</param> | ||
| //public static void Close(string? dialogIdentifier) | ||
| // => Close(dialogIdentifier, null); |
There was a problem hiding this comment.
This would be a breaking change. Probably this is needs to use fallback if there is an single dialog open currently.
There was a problem hiding this comment.
public static void Close(string? dialogIdentifier, object? parameter = null, object? content = null)
There was a problem hiding this comment.
This is fine source-wise, but this is still a binary breaking change. Any library that use the old removed Close methods must be recompiled against the new version, or using it with the new DialogHost version will throw the MethodMissingException.
|
I've messed up with git, and accidently pushed your commits to my main branch essentially merging this PR. Also, i've rollbacked the close methods removal to avoid breaking change. |
ok |
2 participants
fix close dialog bug when
IsMultipleDialogsEnabled=true