Admin Menu: Consolidate "Dashboard" and "My Home" menus #43983

mmtr · 2025-06-17T14:39:05Z

Proposed changes:

Stops replacing the "Dashboard" menu with "My Home". This way, the "Dashboard" menu is consistently visible across all sites (previously, only visible with the classic admin interface).
Always registers "My Home" as a top-level menu, so it's consistently in the same level across all sites (previously, it was a submenu of "Hosting" on sites with the classic admin interface).

Interface	Site	Before	After
Default	Simple
Default	Atomic
Classic	Simple
Classic	Atomic

Note that the "Dashboard > Updates" submenu is still not visible on Simple sites, so the "Dashboard" menu won't display any submenus. In a follow-up (see DOTCOM-13619), we'll add "Dashboard > Updates" to Simple sites, and this will cause the "Dashboard > Home" to show up.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Apply these changes to a WP.com Simple site and to a WP.com Atomic site.
Test the following scenarios:
- Simple site / Default admin interface (Calypso)
  - Dashboard: ✅ Visible
  - My Home: ✅ Visible
- Atomic site / Default admin interface (Calypso)
  - Dashboard > Home: ✅ Visible
  - Dashboard > Updates: ✅ Visible
  - My Home: ✅ Visible
  - My Home > Updates: ❌ Not visible
- Simple site / Classic admin interface (WP Admin)
  - Dashboard: ✅ Visible
  - My Home: ✅ Visible
  - Hosting > My Home: ❌ Not visible
- Atomic site / Classic admin interface (WP Admin)
  - Dashboard > Home: ✅ Visible
  - Dashboard > Updates: ✅ Visible
  - My Home: ✅ Visible
  - Hosting > My Home: ❌ Not visible

github-actions · 2025-06-17T14:39:53Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-13618-untangling-ia-dashboard-home branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack dotcom-13618-untangling-ia-dashboard-home

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-13618-untangling-ia-dashboard-home

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-06-17T14:40:09Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-06-17T14:51:55Z

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/masterbar/src/admin-menu/class-base-admin-menu.php	168/244 (68.85%)	-1.64%	4 💔
projects/packages/masterbar/src/admin-menu/class-atomic-admin-menu.php	75/161 (46.58%)	0.29%	-1 💚
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php	0/297 (0.00%)	0.00%	-2 💚
projects/packages/masterbar/src/admin-menu/class-admin-menu.php	179/228 (78.51%)	0.49%	-2 💚
projects/packages/masterbar/src/admin-menu/class-wpcom-admin-menu.php	43/154 (27.92%)	0.36%	-2 💚

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

projects/packages/masterbar/src/admin-menu/class-admin-menu.php

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php

xavier-lc

Works as described

…ing-ia-dashboard-home

BogdanUngureanu · 2025-06-18T10:09:36Z

Tests well on Simple and Atomic, however, there's a small priority issue on p2s.

By moving the My home out of hosting for classic interface, it means the overview would become the default page. Not a problem, but it would be interesting to see what's the impact of this (more domains, more staging sites usage, etc) since in theory it would receive more exposure.

mmtr · 2025-06-18T10:20:03Z

there's a small priority issue on p2s.

Actually, it's not only P2s, but all sites. Great catch. And like you said, not a problem, but would be nice if as a side effect of this change users are more aware of the Hosting Dashboard.

BogdanUngureanu · 2025-06-18T10:23:23Z

there's a small priority issue on p2s.

Actually, it's not only P2s, but all sites. Great catch. And like you said, not a problem, but would be nice if as a side effect of this change users are more aware of the Hosting Dashboard.

Sorry, I should've been more clear. That comment is about two separate things :D

The priority problem on p2s (My home is not besides the Dashboard) (small bug)
The default page of Hosting is now different on all sites (not a bug)

mmtr · 2025-06-18T11:04:04Z

The priority problem on p2s (My home is not besides the Dashboard) (small bug)

Got it, thanks for clarifying! Just pushed a fix for that, along with another fix to prevent the "My Home" menu from being visible to super admins who are not members of the site (and thus without Calypso access for that site).

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php

BogdanUngureanu

LGTM! 🚢

…ing-ia-dashboard-home

- Stops replacing the "Dashboard" menu with "My Home". This way, the "Dashboard" menu is consistently visible across all sites (previously, only visible with the classic admin interface). - Always registers "My Home" as a top-level menu, so it's consistently in the same level across all sites (previously, it was a submenu of "Hosting" on sites with the classic admin interface).

mmtr added 2 commits June 17, 2025 16:08

Admin Menu: Consolidate "Dashboard" and "My Home" menus

83352a4

Remove "Hosting > My Home" submenu

5904b0b

mmtr self-assigned this Jun 17, 2025

mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Jun 17, 2025

github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] Masterbar labels Jun 17, 2025

Remove no longer needed code

0fc83b8

github-actions bot added the [Tests] Includes Tests label Jun 17, 2025

mmtr added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jun 17, 2025

mmtr requested a review from a team June 17, 2025 15:03

BogdanUngureanu reviewed Jun 17, 2025

View reviewed changes

projects/packages/masterbar/src/admin-menu/class-admin-menu.php Outdated Show resolved Hide resolved

BogdanUngureanu reviewed Jun 17, 2025

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php Show resolved Hide resolved

Remove function, since there are not mid-deploy fatals in Jetpack

9c7e95c

xavier-lc previously approved these changes Jun 18, 2025

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into dotcom-13618-untangl…

8df65e9

…ing-ia-dashboard-home

mmtr added 2 commits June 18, 2025 12:56

Prevent the "My Home" menu from being visible to super admins

6847554

Fix menu order on P2 sites

f0124a9

mmtr dismissed xavier-lc’s stale review via f0124a9 June 18, 2025 11:02

BogdanUngureanu reviewed Jun 18, 2025

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php Show resolved Hide resolved

BogdanUngureanu approved these changes Jun 18, 2025

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into dotcom-13618-untangl…

ff77a86

…ing-ia-dashboard-home

mmtr merged commit bed5306 into trunk Jun 19, 2025
67 checks passed

mmtr deleted the dotcom-13618-untangling-ia-dashboard-home branch June 19, 2025 13:17

github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jun 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Admin Menu: Consolidate "Dashboard" and "My Home" menus #43983

Admin Menu: Consolidate "Dashboard" and "My Home" menus #43983

Uh oh!

mmtr commented Jun 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

jp-launch-control bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

xavier-lc left a comment

Uh oh!

BogdanUngureanu commented Jun 18, 2025 •

edited

Loading

Uh oh!

mmtr commented Jun 18, 2025

Uh oh!

BogdanUngureanu commented Jun 18, 2025 •

edited

Loading

Uh oh!

mmtr commented Jun 18, 2025

Uh oh!

Uh oh!

BogdanUngureanu left a comment

Uh oh!

Uh oh!

Uh oh!

Admin Menu: Consolidate "Dashboard" and "My Home" menus #43983

Admin Menu: Consolidate "Dashboard" and "My Home" menus #43983

Uh oh!

Conversation

mmtr commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

jp-launch-control bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

Uh oh!

xavier-lc left a comment

Choose a reason for hiding this comment

Uh oh!

BogdanUngureanu commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmtr commented Jun 18, 2025

Uh oh!

BogdanUngureanu commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmtr commented Jun 18, 2025

Uh oh!

Uh oh!

BogdanUngureanu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mmtr commented Jun 17, 2025 •

edited

Loading

github-actions bot commented Jun 17, 2025 •

edited

Loading

jp-launch-control bot commented Jun 17, 2025 •

edited

Loading

BogdanUngureanu commented Jun 18, 2025 •

edited

Loading

BogdanUngureanu commented Jun 18, 2025 •

edited

Loading