Skip to content

Conversation

@BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Mar 13, 2024

Changes proposed in this pull request

  • Fix missing semicolon

Issues fixed in this pull request

Admittedly my C++ knowledge is limited and I'm not even sure whether this would be a bug originally or it just ends up being 'cosmetics'. I suspect at the very least that not having a semicolon there might have unexpected behavior - so this at least matches things cosmetically.

@cpichard
Copy link
Collaborator

Hi @BigRoy ,
thanks for the contribution, would you be able to send us the CLA signed ( https://github.com/Autodesk/arnold-usd/blob/master/CONTRIBUTING.md ) ? We need that in order to merge the PRs.
Thanks,
Cyril

@BigRoy
Copy link
Contributor Author

BigRoy commented Mar 14, 2024

Hi @BigRoy , thanks for the contribution, would you be able to send us the CLA signed ( https://github.com/Autodesk/arnold-usd/blob/master/CONTRIBUTING.md ) ? We need that in order to merge the PRs. Thanks, Cyril

Hi Cyril, no problem. There are existing commits by me in the repo so I wonder if I had already done this in the past actually. :) Five years ago!

@cpichard
Copy link
Collaborator

Hi,
we didn't find you in the list I am afraid, may be those commits date before legal requirements ?
Thanks again,
C

@sebastienblor sebastienblor self-requested a review March 19, 2024 15:05
@sebastienblor sebastienblor merged commit 4fa5369 into Autodesk:master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants