add PHPDoc hints for IDE property support in traits #457
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mitoop <[email protected]>
|
@Gummibeer Could you have a review? |
Gummibeer
reviewed
Jul 2, 2025
src/Translatable/Translatable.php
Outdated
| @@ -16,6 +16,7 @@ | |||
| * @property-read string $translationForeignKey | |||
| * @property-read string $localeKey | |||
| * @property-read bool $useTranslationFallback | |||
| * @property array $translatedAttributes | |||
There was a problem hiding this comment.
Shouldn't it be one of these then?
Suggested change
| * @property array $translatedAttributes | |
| * @property string[] $translatedAttributes |
or
Suggested change
| * @property array $translatedAttributes | |
| * @property array<array-key, string> $translatedAttributes |
There was a problem hiding this comment.
chose this one
* @property string[] $translatedAttributes
Signed-off-by: mitoop <[email protected]>
Gummibeer
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PHPDoc annotation for the
$translatedAttributesproperty to improve IDE support and developer experience when working with translatable models. It helps make the expected structure and usage of this property clearer during development.