Skip to content

BREAKING CHANGE: Refactor enum identifiers to TitleCase and apply some changes in AST nodes #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Oct 23, 2022
Merged

BREAKING CHANGE: Refactor enum identifiers to TitleCase and apply some changes in AST nodes #2501

merged 31 commits into from
Oct 23, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Sep 4, 2022 •
edited
Loading

Changes:

  • Canonicalize all enum identifiers from mixed (UPPER, UPPER_SNAKE and TitleCase) case to TitleCase only
  • Rename statement to body in all loop-related AST nodes in ast.ts
  • Rename statements to bodyStatements for TryStatement node in ast.ts
  • Add Node > .isEmpty in ast.ts
  • Add SwitchCase > .isDefault in ast.ts
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO September 4, 2022 05:35
@MaxGraey MaxGraey changed the title [NFC] Rename statement to body in all loop-related AST nodes BREAKING CHANGE: Rename statement to body in all loop-related AST nodes Sep 4, 2022
@MaxGraey MaxGraey changed the title BREAKING CHANGE: Rename statement to body in all loop-related AST nodes BREAKING CHANGE: Rename statement to body in all loop-related AST nodes and the same for TryStatment Sep 4, 2022
@MaxGraey MaxGraey changed the title BREAKING CHANGE: Rename statement to body in all loop-related AST nodes and the same for TryStatment BREAKING CHANGE: Rename statement to body in all loop-related AST nodes and the same for TryStatement Sep 4, 2022
@MaxGraey MaxGraey marked this pull request as draft September 4, 2022 21:42
@MaxGraey MaxGraey changed the title BREAKING CHANGE: Rename statement to body in all loop-related AST nodes and the same for TryStatement BREAKING CHANGE: Refactor enum identifiers to TitleCase and apply some changes in AST nodes Sep 4, 2022
@MaxGraey MaxGraey marked this pull request as ready for review September 5, 2022 09:55
dcodeIO
dcodeIO reviewed Oct 23, 2022
View reviewed changes
dcodeIO
dcodeIO reviewed Oct 23, 2022
View reviewed changes
dcodeIO
dcodeIO reviewed Oct 23, 2022
View reviewed changes
dcodeIO
dcodeIO reviewed Oct 23, 2022
View reviewed changes
@MaxGraey MaxGraey requested a review from dcodeIO October 23, 2022 15:18
@dcodeIO dcodeIO merged commit a7d10ba into AssemblyScript:main Oct 23, 2022
@MaxGraey MaxGraey deleted the refactor-ast branch October 23, 2022 20:23
CountBleck added a commit to CountBleck/visitor-as that referenced this pull request Nov 14, 2022
@CountBleck @jtenner
Update *Kind members as per AssemblyScript/assemblyscript#2501
7391083 
AssemblyScript now uses Pascal case in its *Kind enums, so this commit
changes visitor-as's usage accordingly. AssemblyScript also renamed the
"statements" member in some Nodes to "body". That change has also been
accounted for. Finally, transformRange.ts, an unused file, has now been
deleted.

Co-authored-by: Joshua Tenner <[email protected]>
@HerrCai0907 HerrCai0907 mentioned this pull request Dec 8, 2022
Merged
@romdotdog romdotdog mentioned this pull request Dec 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO