Skip to content

Defuse assertion when mixing managed and unmanaged classes #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Sep 12, 2021

Fixes #2067 where a managed / unmanaged mismatch is diagnosed but before it is reported triggers an assertion in runtime visitor logic.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@eXponenta
Copy link

eXponenta commented Sep 13, 2021

Very strange error description.
In test case managed class try to extends unmanaged, error said that we extends a unmanaged from managed.

This means that error should be produced by this:

class Base { }

@unmanaged
class Foo extends Base {}

@dcodeIO
Copy link
Member Author

dcodeIO commented Sep 13, 2021

The full error message is:

"Unmanaged classes cannot extend managed classes and vice-versa.": 207,

I only used part of it for the stderr test.

@dcodeIO dcodeIO merged commit 647cc5e into main Sep 13, 2021
@dcodeIO dcodeIO deleted the issue-2067 branch September 14, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during compile @unmanaged and managed classes
2 participants