Use correct data length in Array#flat #2058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2018 where it was discovered that
Array#flat
erroneously used the backing buffer's byteLength instead of its length, leading to an OOBmemory.copy
into subsequent data.In the concrete repro, the array header was overwritten with zeroes, leading to the reported effect when the backing buffer is larger than the length, say after a resize triggered by
push
.