Skip to content

Use correct data length in Array#flat #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Use correct data length in Array#flat #2058

merged 2 commits into from
Sep 10, 2021

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Sep 10, 2021

Fixes #2018 where it was discovered that Array#flat erroneously used the backing buffer's byteLength instead of its length, leading to an OOB memory.copy into subsequent data.

In the concrete repro, the array header was overwritten with zeroes, leading to the reported effect when the backing buffer is larger than the length, say after a resize triggered by push.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@dcodeIO dcodeIO merged commit 5dce4e4 into main Sep 10, 2021
@dcodeIO dcodeIO deleted the issue-2018 branch September 14, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array#flat doesn't work after push in one of the nested arrays
2 participants