feat: Add __getFunction method for loader #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
changed the title
dcodeIO
reviewed
Aug 16, 2021
dcodeIO
reviewed
Aug 16, 2021
dcodeIO
approved these changes
Aug 17, 2021
MaxGraey
commented
Aug 28, 2021
Comment on lines
+49
to
+51
| Object.hasOwn = Object.hasOwn || function(obj, prop) { | ||
| return Object.prototype.hasOwnProperty.call(obj, prop); | ||
| }; |
There was a problem hiding this comment.
trusktr
reviewed
Sep 5, 2021
| if (!table) throw Error(E_NO_EXPORT_TABLE); | ||
| const index = new Uint32Array(memory.buffer)[ptr >>> 2]; | ||
| return table.get(index); | ||
| } |
There was a problem hiding this comment.
Isn't this slower than passing the fn.index from AS to JS? It could be
function __getFunction(index) {
if (!table) throw Error(E_NO_EXPORT_TABLE);
return table.get(index);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some refactoring and code reusage