Optimize loader string encoding routine #1913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmm, checked with a larger string now, and it's not anymore. The inconsistency in between browsers is already amazing, but that is strange. |
MaxGraey
reviewed
Jun 18, 2021
| const ptr = __new(size, STRING_ID); | ||
|
|
||
| const U16 = new Uint16Array(memory.buffer); | ||
| const buf = new Uint8Array(memory.buffer, ptr, size); |
Member
There was a problem hiding this comment.
Is it really faster with ptr and size in constructor? When I last time checked it was less efficient than original approach
2 tasks
Member
Author
|
There is quite a bit of uncertainty around how and when this is faster. Would probably be best if browsers would just deal with JS strings better. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, using an
Uint8Arraywhen encoding a string is up to 5x faster. Speedup depends on the browser a bit, but seems to be universal across major engines.