Not working with React 19

[austinwilcox]

It appears that the plugin is no longer working after I upgraded a Vite/React project to React 19 and Vite 6. Is that expected behavior or am I potentially missing something else?

[ArnaudBarre]

This seems possible that this breaks with React 19, I didn't try it out yet. I look into it on Monday.
Do you have an up to date version of React devtools installed, the code path is different when it's installed: https://github.com/ArnaudBarre/vite-plugin-react-click-to-component/blob/main/src/client.ts#L178

[austinwilcox]

I talked to the developer on my team having issues, and it looks it was a weird state with pnpm/Windows. He says it's all working just fine now. Thanks for the response. I'll go ahead and close the issue.

[ArnaudBarre]

So this is actually broken in React 19: facebook/react#28265
The solution is to use some code from facebook/react#28351
I'll try to work on that this week!

[ArnaudBarre]

Took a bit longer (because of Factorio Space age ⚙️), but I've published v3.1.0 that do a hacky patch to get things working. I hope I'll get an answer from the React team on how to do it more cleanly in the future!

[nfarina]

Wonderful, I'm so happy to have this working again!!