Skip to content

Improve the docs and behavior around infinite retries#1574

Merged
martintmk merged 1 commit intomainfrom
mtomka/docs-infinite-retries
Sep 8, 2023
Merged

Improve the docs and behavior around infinite retries#1574
martintmk merged 1 commit intomainfrom
mtomka/docs-infinite-retries

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Sep 8, 2023

Details on the issue fix or feature implementation

  • Using int.MaxValue will indicate infinite retries to retry strategy.
  • Docs improvements.

Closes #944

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 8, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 8, 2023
@martintmk martintmk force-pushed the mtomka/docs-infinite-retries branch from ac6f17e to 3724183 Compare September 8, 2023 07:57
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (2ef9ae0) 83.92% compared to head (3724183) 83.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
+ Coverage   83.92%   83.93%   +0.01%     
==========================================
  Files         279      279              
  Lines        6520     6525       +5     
  Branches     1017     1019       +2     
==========================================
+ Hits         5472     5477       +5     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.93% <100.00%> (+0.01%) ⬆️
windows 83.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) September 8, 2023 08:35
@martintmk martintmk merged commit 2c07f35 into main Sep 8, 2023
@martintmk martintmk deleted the mtomka/docs-infinite-retries branch September 8, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

RetryForever - Documentation improvment?

2 participants