BreakDurationGenerator not passed to CircuitStateController

[martincostello]

          There is an issue with this. When you call AddCircuitBreaker(options), having specified BreakDurationGenerator. It does not pass the generate to the CircuitStateController. So the resulting circuitbreaker will use the default 5 seconds fixed duration.

Originally posted by @adminnz in #1776 (comment)

[adminnz]

Not sure what more to add, the BreakDurationGenerator does not get passed to the controller.

So if you do:

        ResiliencePipeline = new ResiliencePipelineBuilder()
           .AddCircuitBreaker(new CircuitBreakerStrategyOptions
           {
               BreakDurationGenerator = args => ValueTask.FromResult(TimeSpan.FromMinutes(args.FailureCount)),
               MinimumThroughput = Settings.CircuitBreakerMinimumThroughput,
               FailureRatio = Settings.CircuitBreakerFailureRatio,
               SamplingDuration = Settings.CircuitBreakerSamplingDuration,
               StateProvider = CircuitBreakerStateProvider,
               OnClosed = OnCircuitClosed,
               OnOpened = OnCircuitOpened,
               OnHalfOpened = OnHalfOpened
           })
           .Build();

The resulting ResiliencePipline circuit breaker will not use the BreakDurationGenerator. Instead it will use the default 5 second BreakDuration.

[martincostello]

Thanks - it was a concrete code snippet I was after so that we can use it to build up a unit test.