Update codebase and SplashScreen implementation #3
Conversation
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
unnecessary empty lines
| modifier = Modifier.fillMaxSize(), | ||
| color = colorResource(id = R.color.app_black) | ||
| ) { | ||
| showSplash() |
There was a problem hiding this comment.
explore this api - androidx.core:core-splashscreen
| horizontalAlignment = Alignment.CenterHorizontally, | ||
|
|
||
| ) { | ||
| val ctx = LocalContext.current; |
There was a problem hiding this comment.
variable naming could be more better
|
|
||
| ) { | ||
| val ctx = LocalContext.current; | ||
| Text(text = "Welcome", color = colorResource(id = R.color.white), fontWeight = FontWeight.Bold, |
|
|
||
| ) { | ||
| val ctx = LocalContext.current; | ||
| Text(text = "Welcome", color = colorResource(id = R.color.white), fontWeight = FontWeight.Bold, |
There was a problem hiding this comment.
color can be use from Color.kt file
|
|
||
|
|
| contentDescription ="image", | ||
| alignment = Alignment.Center, | ||
|
|
||
| modifier = Modifier.matchParentSize() |
|
In " androidx.core:core-splashscreen" api need to resize icon that takes lot of time from my side ,so I decided explore more animation . New changes added lottie animation with jetpack compose. Will update more UI in next PR. |
| ) { //Surface(modifier = Modifier.fillMaxSize(), color = colorScheme.background) { | ||
| // Lottie animation screen. | ||
| ComposeLottieScreen() | ||
| //} |
| @Composable | ||
| fun ComposeLottieScreen() { | ||
|
|
There was a problem hiding this comment.
Can we have a separate file for these UI functions?
| horizontalAlignment = CenterHorizontally, | ||
|
|
||
| ) { | ||
| val sContext = LocalContext.current |
There was a problem hiding this comment.
what does s stands for in sContext?
|
update the changes with name and create new file for the splash-screen module |
| ) { | ||
| val sContext = LocalContext.current | ||
| Text( | ||
| text = sContext.getString(R.string.welcome), |
| } | ||
| } | ||
|
|
||
| private fun isInternetAvailable(context: Context): Boolean { |
Basic splashscreen and icon added