Skip to content

Conversation

@matthieu-crouzet
Copy link
Contributor

Proposed change

Related issues

- No issue associated -

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner December 16, 2025 13:47
@nx-cloud
Copy link

nx-cloud bot commented Dec 16, 2025

View your CI Pipeline Execution ↗ for commit 69c69a2

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded <1s View ↗
nx affected --target=test --collectCoverage --c... ✅ Succeeded 3s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 5s View ↗
nx run-many --tui=false --target=build --projec... ✅ Succeeded 1s View ↗
nx run-many --target=documentation ✅ Succeeded 4s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 32s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 2s View ↗
nx affected --target=package-github-action ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-16 16:50:59 UTC

@github-actions github-actions bot added the enhancement New feature or request label Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.50%. Comparing base (65c98d7) to head (69c69a2).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthieu-crouzet matthieu-crouzet force-pushed the feat/windsurf-rules branch 3 times, most recently from 64f5101 to 266868f Compare December 16, 2025 14:20
| Scope | Purpose | Angular |
|-------|---------|---------|
| `@o3r/*` | Core Otter framework libraries | Yes |
| `@ama-sdk/*` | SDK generation and client utilities | Partial |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to explicit what Partial means here
I suppose it means only @angular-cli ? or is it linked to client-angular ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's link to the client-angular
either all scopes would have Partial because of ng-add schematics

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it then make sense to change it to schematics only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All have schematics so I didn't mention them,
Partial is because @ama-sdk/client-angular is in Angular

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said during meeting I think we should give it a try like that and adapt step by step if we detect that windsurf has to verify structure by itself before answering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants