-
Notifications
You must be signed in to change notification settings - Fork 44
feat: add windsurf rules #3819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add windsurf rules #3819
Conversation
|
View your CI Pipeline Execution ↗ for commit 69c69a2
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
64f5101 to
266868f
Compare
266868f to
69c69a2
Compare
| | Scope | Purpose | Angular | | ||
| |-------|---------|---------| | ||
| | `@o3r/*` | Core Otter framework libraries | Yes | | ||
| | `@ama-sdk/*` | SDK generation and client utilities | Partial | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to explicit what Partial means here
I suppose it means only @angular-cli ? or is it linked to client-angular ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's link to the client-angular
either all scopes would have Partial because of ng-add schematics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it then make sense to change it to schematics only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All have schematics so I didn't mention them,
Partial is because @ama-sdk/client-angular is in Angular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said during meeting I think we should give it a try like that and adapt step by step if we detect that windsurf has to verify structure by itself before answering
Proposed change
Related issues
- No issue associated -